Add client-set proxy headers to PDS #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, so this will allow clients to easily hook into custom AppViews for non-Bluesky use-cases? 👀 |
|
Yup yup exactly! This is actually needed for the composable mod services feature we're working on, but it will also allow a client to configuring a different appview to communicate with. Unfortunately it still only works for |
devinivy
reviewed
Mar 1, 2024
| ctx: AppContext, | ||
| path: string, | ||
| ): { url: string; did: string } | null => { | ||
| const nsid = path.replace('/xrpc/', '') |
There was a problem hiding this comment.
A few misc things to maybe just peek at here:
- Do we need to check that the path starts with
/xrpctoo? - May want to handle trailing slash in the URL, I believe the pds routing permits it.
- Express's
req.urlis relative to the nearest router or something like that, I forget the details but may be relevant since I know it gets passed here. There is alsoreq.originalUrlwhich might be more reliable for us.
add runit to the services/bsky Dockerfile
* Allow tags to lead with and contain only numbers * Break tags on other whitespace characters * Export regexes from rich text detection * Add test * Add test * Disallow number-only tags * Avoid combining enclosing screen chars * Allow full-width number sign * Clarify tests * Fix punctuation edge case * Reorder * Simplify, add another test * Another test, comment
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* ozone delegates email sending to user's pds * lexicon: add content field to mod email event * test email sending via mod event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to set an
atproto-proxyheader to a request to inform a PDS where it should forward that message to (with service auth). Currently only works for specced methods.The syntax is
atproto-proxy: ${did}#${serviceId}. For instance:atproto-proxy: did:web:api.bsky.app#bsky_appview.When unset, the request falls back to the current PDS configuration